Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always send html plot content to a proxy server #4876

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

sharon-wang
Copy link
Member

Description

A follow-up to #4806 to revert src/vs/workbench/services/languageRuntime/common/languageRuntimeUiClient.ts back to using a proxy for interactive plots. A generic HTTP proxy was added via #4855, so server plots can be proxied appropriately in Server Web and Workbench.

Related to

QA Notes

On Server Web and Workbench, running the following in the corresponding consoles:

Python

pip install plotly nbformat pandas

import plotly.express as px
fig = px.bar(x=["a", "b", "c"], y=[1, 3, 2])
fig.show()
R

install.packages('plotly')

library(plotly)
fig <- plot_ly(data = iris, x = ~Sepal.Length, y = ~Petal.Length)
fig

Expected Result

The corresponding interactive plots should display in the plots pane and be interact-able!

we determine the appropriate proxy server type (static HTML or generic HTTP) based on the URI scheme of the file path.
@sharon-wang sharon-wang requested a review from timtmok October 2, 2024 18:20
Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sharon-wang sharon-wang merged commit 20a2eac into main Oct 2, 2024
3 checks passed
@sharon-wang sharon-wang deleted the use-proxy-for-html-plots branch October 2, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants